MIPS: alchemy: add return value check for strict_strtoul()
diff mbox

Message ID 20101108172352.db48962c.yuasa@linux-mips.org
State Accepted
Delegated to: Ralf Baechle
Headers show

Commit Message

Yoichi Yuasa Nov. 8, 2010, 8:23 a.m. 
arch/mips/alchemy/devboards/prom.c: In function 'prom_init':
arch/mips/alchemy/devboards/prom.c:60: error: ignoring return value of
'strict_strtoul', declared with attribute warn_unused_result

Signed-off-by: Yoichi Yuasa <yuasa@linux-mips.org>
---
 arch/mips/alchemy/devboards/prom.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

Comments

root Nov. 8, 2010, 10:01 p.m. | #1 
Thanks, applied.

  Ralf

Patch
diff mbox 

diff --git a/arch/mips/alchemy/devboards/prom.c b/arch/mips/alchemy/devboards/prom.c
index b30df5c..baeb213 100644
--- a/arch/mips/alchemy/devboards/prom.c
+++ b/arch/mips/alchemy/devboards/prom.c
@@ -54,10 +54,9 @@  void __init prom_init(void)
 
 	prom_init_cmdline();
 	memsize_str = prom_getenv("memsize");
-	if (!memsize_str)
+	if (!memsize_str || strict_strtoul(memsize_str, 0, &memsize))
 		memsize = ALCHEMY_BOARD_DEFAULT_MEMSIZE;
-	else
-		strict_strtoul(memsize_str, 0, &memsize);
+
 	add_memory_region(0, memsize, BOOT_MEM_RAM);
 }