Patchworkβ MIPS: Fix __devinit __cpuinit confusion in cpu_cache_init

login
register
about
Submitter David Daney
Date 2010-02-04 23:48:49
Message ID <1265327329-2949-1-git-send-email-ddaney@caviumnetworks.com>
Download mbox | patch
Permalink /patch/938/
State Accepted
Delegated to: Ralf Baechle
Headers show

Comments

David Daney - 2010-02-04 23:48:49
cpu_cache_init and the things it calls should all be __cpuinit instead
of __devinit.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
 arch/mips/mm/c-octeon.c |    4 ++--
 arch/mips/mm/cache.c    |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
Ralf Baechle - 2010-02-05 06:36:56
On Thu, Feb 04, 2010 at 03:48:49PM -0800, David Daney wrote:

> cpu_cache_init and the things it calls should all be __cpuinit instead
> of __devinit.
> 
> Signed-off-by: David Daney <ddaney@caviumnetworks.com>

Thanks,

  Ralf

Patch

diff --git a/arch/mips/mm/c-octeon.c b/arch/mips/mm/c-octeon.c
index e75174a..af85959 100644
--- a/arch/mips/mm/c-octeon.c
+++ b/arch/mips/mm/c-octeon.c
@@ -174,7 +174,7 @@  static void octeon_flush_cache_page(struct vm_area_struct *vma,
  * Probe Octeon's caches
  *
  */
-static void __devinit probe_octeon(void)
+static void __cpuinit probe_octeon(void)
 {
 	unsigned long icache_size;
 	unsigned long dcache_size;
@@ -235,7 +235,7 @@  static void __devinit probe_octeon(void)
  * Setup the Octeon cache flush routines
  *
  */
-void __devinit octeon_cache_init(void)
+void __cpuinit octeon_cache_init(void)
 {
 	extern unsigned long ebase;
 	extern char except_vec2_octeon;
diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c
index 102b2df..e716caf 100644
--- a/arch/mips/mm/cache.c
+++ b/arch/mips/mm/cache.c
@@ -155,7 +155,7 @@  static inline void setup_protection_map(void)
 	protection_map[15] = PAGE_SHARED;
 }
 
-void __devinit cpu_cache_init(void)
+void __cpuinit cpu_cache_init(void)
 {
 	if (cpu_has_3k_cache) {
 		extern void __weak r3k_cache_init(void);