Patchwork [2/2] Loongson: disable FLATMEM

login
register
mail settings
Submitter Wu Zhangjin
Date 2009-12-01 06:12:42
Message ID <1259650542-31922-1-git-send-email-wuzhangjin@gmail.com>
Download mbox | patch
Permalink /patch/737/
State Accepted
Delegated to: Ralf Baechle
Headers show

Comments

Wu Zhangjin - 2009-12-01 06:12:42
From: Wu Zhangjin <wuzhangjin@gmail.com>

With FLATMEM, The STD(Hibernation) for Loongson will fail, and there are
also some other problems(break the files) when using NFS or CIFS(samba).

And as the config help of SPARSEMEM says:

"This option provides some potential performance benefits, along with
decreased code complexity."

So, to avoid the potential problems of FLATMEM, we disable FLATMEM
directly and use SPARSEMEM instead.

Relative Email thread:

http://groups.google.com/group/loongson-dev/browse_thread/thread/b6b65890ec2b0f24/feb43e5aa7f55d9b?show_docid=feb43e5aa7f55d9b

Reported-by: Tatu Kilappa <tatu.kilappa@gmail.com>
Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
---
 arch/mips/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Ralf Baechle - 2009-12-01 03:12:46
On Tue, Dec 01, 2009 at 02:55:42PM +0800, Wu Zhangjin wrote:

> With FLATMEM, The STD(Hibernation) for Loongson will fail, and there are
> also some other problems(break the files) when using NFS or CIFS(samba).
> 
> And as the config help of SPARSEMEM says:
> 
> "This option provides some potential performance benefits, along with
> decreased code complexity."
> 
> So, to avoid the potential problems of FLATMEM, we disable FLATMEM
> directly and use SPARSEMEM instead.
> 
> Relative Email thread:
> 
> http://groups.google.com/group/loongson-dev/browse_thread/thread/b6b65890ec2b0f24/feb43e5aa7f55d9b?show_docid=feb43e5aa7f55d9b
> 
> Reported-by: Tatu Kilappa <tatu.kilappa@gmail.com>
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>

Applied - though I'm not so sure if I can get this one to Linus as
close to a release as we are now.

Thanks!

  Ralf

Patch

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 8bf36d2..0be245d 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -1835,7 +1835,7 @@  config SYS_SUPPORTS_SMARTMIPS
 
 config ARCH_FLATMEM_ENABLE
 	def_bool y
-	depends on !NUMA
+	depends on !NUMA && !CPU_LOONGSON2
 
 config ARCH_DISCONTIGMEM_ENABLE
 	bool