From patchwork Thu Nov 26 18:30:07 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: MIPS asm/mman.h and MADV_HWPOISON Date: Thu, 26 Nov 2009 17:30:07 -0000 From: Ralf Baechle X-Patchwork-Id: 723 Message-Id: <20091126183007.GA19853@linux-mips.org> To: "Joseph S. Myers" Cc: linux-mips@linux-mips.org On Wed, Nov 25, 2009 at 11:57:07PM +0000, Joseph S. Myers wrote: > In the course of updating glibc ports's bits/mman.h files for new MADV_* > definitions, I noticed that arch/mips/include/asm/mman.h does not define > MADV_HWPOISON, although architectures using asm-generic/mman.h get that > definition automatically. Should I take it that this is an oversight and > that a definition of MADV_HWPOISON will be added with value 100, or is > there some reason for it not to be defined for MIPS or for it to have a > different value? Just an omission. Thanks for reporting. I've just checked in below patch. Ralf From: Ralf Baechle MIPS: Add missing definition for MADV_HWPOISON. Signed-off-by: Ralf Baechle diff --git a/arch/mips/include/asm/mman.h b/arch/mips/include/asm/mman.h index a2250f3..c892bfb 100644 --- a/arch/mips/include/asm/mman.h +++ b/arch/mips/include/asm/mman.h @@ -75,6 +75,7 @@ #define MADV_MERGEABLE 12 /* KSM may merge identical pages */ #define MADV_UNMERGEABLE 13 /* KSM may not merge identical pages */ +#define MADV_HWPOISON 100 /* poison a page for testing */ /* compatibility flags */ #define MAP_FILE 0