Patchwork MIPS: bcm63xx: clk: Add dummy clk_set_rate() function

login
register
mail settings
Submitter Markos Chandras
Date 2013-07-01 10:07:24
Message ID <1372676244-1399-1-git-send-email-markos.chandras@imgtec.com>
Download mbox | patch
Permalink /patch/5576/
State Rejected
Delegated to: Ralf Baechle
Headers show

Comments

Markos Chandras - 2013-07-01 10:07:24
Several drivers use the clk_set_rate() function that needs
to be defined in the platform's clock code. The Broadcom
BCM63xx platform hardcodes the clock rate so we create a new
dummy clk_set_rate() function which just returns -EINVAL.

Also fixes the following build problem on a randconfig:
drivers/built-in.o: In function `nop_usb_xceiv_probe':
phy-nop.c:(.text+0x3ec26c): undefined reference to `clk_set_rate'

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
Acked-by: Steven J. Hill <Steven.Hill@imgtec.com> 
---
This patch is for the upstream-sfr/mips-for-linux-next tree
---
 arch/mips/bcm63xx/clk.c | 6 ++++++
 1 file changed, 6 insertions(+)
Lars-Peter Clausen - 2013-07-01 11:07:02
On 07/01/2013 12:57 PM, Markos Chandras wrote:
> Several drivers use the clk_set_rate() function that needs
> to be defined in the platform's clock code. The Broadcom
> BCM63xx platform hardcodes the clock rate so we create a new
> dummy clk_set_rate() function which just returns -EINVAL.
> 
> Also fixes the following build problem on a randconfig:
> drivers/built-in.o: In function `nop_usb_xceiv_probe':
> phy-nop.c:(.text+0x3ec26c): undefined reference to `clk_set_rate'
> 
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com> 

To make the set complete clk_round_rate() should be added as well

> ---
> This patch is for the upstream-sfr/mips-for-linux-next tree
> ---
>  arch/mips/bcm63xx/clk.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
> index c726a97..70dcc52 100644
> --- a/arch/mips/bcm63xx/clk.c
> +++ b/arch/mips/bcm63xx/clk.c
> @@ -318,6 +318,12 @@ unsigned long clk_get_rate(struct clk *clk)
>  
>  EXPORT_SYMBOL(clk_get_rate);
>  
> +int clk_set_rate(struct clk *clk, unsigned long rate)
> +{
> +	return -EINVAL;
> +}
> +EXPORT_SYMBOL_GPL(clk_set_rate);
> +
>  struct clk *clk_get(struct device *dev, const char *id)
>  {
>  	if (!strcmp(id, "enet0"))
Markos Chandras - 2013-07-01 01:07:06
On 07/01/13 12:06, Lars-Peter Clausen wrote:
> On 07/01/2013 12:57 PM, Markos Chandras wrote:
>> Several drivers use the clk_set_rate() function that needs
>> to be defined in the platform's clock code. The Broadcom
>> BCM63xx platform hardcodes the clock rate so we create a new
>> dummy clk_set_rate() function which just returns -EINVAL.
>>
>> Also fixes the following build problem on a randconfig:
>> drivers/built-in.o: In function `nop_usb_xceiv_probe':
>> phy-nop.c:(.text+0x3ec26c): undefined reference to `clk_set_rate'
>>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>> Acked-by: Steven J. Hill <Steven.Hill@imgtec.com>
>
> To make the set complete clk_round_rate() should be added as well
>
>> ---
>> This patch is for the upstream-sfr/mips-for-linux-next tree
>> ---
>>   arch/mips/bcm63xx/clk.c | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
>> index c726a97..70dcc52 100644
>> --- a/arch/mips/bcm63xx/clk.c
>> +++ b/arch/mips/bcm63xx/clk.c
>> @@ -318,6 +318,12 @@ unsigned long clk_get_rate(struct clk *clk)
>>
>>   EXPORT_SYMBOL(clk_get_rate);
>>
>> +int clk_set_rate(struct clk *clk, unsigned long rate)
>> +{
>> +	return -EINVAL;
>> +}
>> +EXPORT_SYMBOL_GPL(clk_set_rate);
>> +
>>   struct clk *clk_get(struct device *dev, const char *id)
>>   {
>>   	if (!strcmp(id, "enet0"))
>

Hi Lars,

Thanks. I will submit a new patch

Patch

diff --git a/arch/mips/bcm63xx/clk.c b/arch/mips/bcm63xx/clk.c
index c726a97..70dcc52 100644
--- a/arch/mips/bcm63xx/clk.c
+++ b/arch/mips/bcm63xx/clk.c
@@ -318,6 +318,12 @@  unsigned long clk_get_rate(struct clk *clk)
 
 EXPORT_SYMBOL(clk_get_rate);
 
+int clk_set_rate(struct clk *clk, unsigned long rate)
+{
+	return -EINVAL;
+}
+EXPORT_SYMBOL_GPL(clk_set_rate);
+
 struct clk *clk_get(struct device *dev, const char *id)
 {
 	if (!strcmp(id, "enet0"))