Patchwork mips/txx9: Add missing MODULE_ALIAS definitions for txx9 platform devices

login
register
mail settings
Submitter Geert Uytterhoeven
Date 2010-04-08 06:04:00
Message ID <s2y10f740e81004081152u53d1520fp812bd2defe886220@mail.gmail.com>
Download mbox | patch
Permalink /patch/1101/
State Accepted
Delegated to: Ralf Baechle
Headers show

Comments

Geert Uytterhoeven - 2010-04-08 06:04:00
Hi Nemoto-san, Ralf-san,

I need the patch below to enable autoloading of the TXx9 sound driver
on my RBTX4927.
It works very nice as a low-power MPD player.

From 0902bacfe10db79472c7ecd35ac28f1c02f72101 Mon Sep 17 00:00:00 2001
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Thu, 8 Apr 2010 20:46:28 +0200
Subject: [PATCH] mips/txx9: Add missing MODULE_ALIAS definitions for
txx9 platform devices

This enables autoloading of the TXx9 sound driver on my RBTX4927.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/dma/txx9dmac.c            |    2 ++
 sound/soc/txx9/txx9aclc-ac97.c    |    1 +
 sound/soc/txx9/txx9aclc-generic.c |    1 +
 3 files changed, 4 insertions(+), 0 deletions(-)
Atsushi Nemoto - 2010-04-09 02:04:31
On Thu, 8 Apr 2010 20:52:00 +0200, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> I need the patch below to enable autoloading of the TXx9 sound driver
> on my RBTX4927.
> It works very nice as a low-power MPD player.

Thank you, good news.

> Subject: [PATCH] mips/txx9: Add missing MODULE_ALIAS definitions for
> txx9 platform devices
> 
> This enables autoloading of the TXx9 sound driver on my RBTX4927.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Ralf Baechle - 2010-04-10 10:04:48
On Thu, Apr 08, 2010 at 08:52:00PM +0200, Geert Uytterhoeven wrote:

> Hi Nemoto-san, Ralf-san,
> 
> I need the patch below to enable autoloading of the TXx9 sound driver
> on my RBTX4927.
> It works very nice as a low-power MPD player.
> 
> >From 0902bacfe10db79472c7ecd35ac28f1c02f72101 Mon Sep 17 00:00:00 2001
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Date: Thu, 8 Apr 2010 20:46:28 +0200
> Subject: [PATCH] mips/txx9: Add missing MODULE_ALIAS definitions for
> txx9 platform devices
> 
> This enables autoloading of the TXx9 sound driver on my RBTX4927.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/dma/txx9dmac.c            |    2 ++
>  sound/soc/txx9/txx9aclc-ac97.c    |    1 +
>  sound/soc/txx9/txx9aclc-generic.c |    1 +
>  3 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/txx9dmac.c b/drivers/dma/txx9dmac.c
> index 3ebc610..75fcf1a 100644
> --- a/drivers/dma/txx9dmac.c
> +++ b/drivers/dma/txx9dmac.c
> @@ -1359,3 +1359,5 @@ module_exit(txx9dmac_exit);
>  MODULE_LICENSE("GPL");
>  MODULE_DESCRIPTION("TXx9 DMA Controller driver");
>  MODULE_AUTHOR("Atsushi Nemoto <anemo@mba.ocn.ne.jp>");
> +MODULE_ALIAS("platform:txx9dmac");
> +MODULE_ALIAS("platform:txx9dmac-chan");
> diff --git a/sound/soc/txx9/txx9aclc-ac97.c b/sound/soc/txx9/txx9aclc-ac97.c
> index 612e18b..0ec20b6 100644
> --- a/sound/soc/txx9/txx9aclc-ac97.c
> +++ b/sound/soc/txx9/txx9aclc-ac97.c
> @@ -254,3 +254,4 @@ module_exit(txx9aclc_ac97_exit);
>  MODULE_AUTHOR("Atsushi Nemoto <anemo@mba.ocn.ne.jp>");
>  MODULE_DESCRIPTION("TXx9 ACLC AC97 driver");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:txx9aclc-ac97");
> diff --git a/sound/soc/txx9/txx9aclc-generic.c
> b/sound/soc/txx9/txx9aclc-generic.c
> index 3175de9..95b17f7 100644
> --- a/sound/soc/txx9/txx9aclc-generic.c
> +++ b/sound/soc/txx9/txx9aclc-generic.c
> @@ -96,3 +96,4 @@ module_exit(txx9aclc_generic_exit);
>  MODULE_AUTHOR("Atsushi Nemoto <anemo@mba.ocn.ne.jp>");
>  MODULE_DESCRIPTION("Generic TXx9 ACLC ALSA SoC audio driver");
>  MODULE_LICENSE("GPL");
> +MODULE_ALIAS("platform:txx9aclc-generic");

Will apply.

A while ago I noticed that all of the MIPS platform device drivers
I looked at did not have MODULE_ALIAS().

  Ralf

Patch

diff --git a/drivers/dma/txx9dmac.c b/drivers/dma/txx9dmac.c
index 3ebc610..75fcf1a 100644
--- a/drivers/dma/txx9dmac.c
+++ b/drivers/dma/txx9dmac.c
@@ -1359,3 +1359,5 @@  module_exit(txx9dmac_exit);
 MODULE_LICENSE("GPL");
 MODULE_DESCRIPTION("TXx9 DMA Controller driver");
 MODULE_AUTHOR("Atsushi Nemoto <anemo@mba.ocn.ne.jp>");
+MODULE_ALIAS("platform:txx9dmac");
+MODULE_ALIAS("platform:txx9dmac-chan");
diff --git a/sound/soc/txx9/txx9aclc-ac97.c b/sound/soc/txx9/txx9aclc-ac97.c
index 612e18b..0ec20b6 100644
--- a/sound/soc/txx9/txx9aclc-ac97.c
+++ b/sound/soc/txx9/txx9aclc-ac97.c
@@ -254,3 +254,4 @@  module_exit(txx9aclc_ac97_exit);
 MODULE_AUTHOR("Atsushi Nemoto <anemo@mba.ocn.ne.jp>");
 MODULE_DESCRIPTION("TXx9 ACLC AC97 driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:txx9aclc-ac97");
diff --git a/sound/soc/txx9/txx9aclc-generic.c
b/sound/soc/txx9/txx9aclc-generic.c
index 3175de9..95b17f7 100644
--- a/sound/soc/txx9/txx9aclc-generic.c
+++ b/sound/soc/txx9/txx9aclc-generic.c
@@ -96,3 +96,4 @@  module_exit(txx9aclc_generic_exit);
 MODULE_AUTHOR("Atsushi Nemoto <anemo@mba.ocn.ne.jp>");
 MODULE_DESCRIPTION("Generic TXx9 ACLC ALSA SoC audio driver");
 MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:txx9aclc-generic");