Patchwork [42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup

login
register
mail settings
Submitter Andrea Gelmini
Date 2010-02-27 04:02:23
Message ID <1267289508-31031-43-git-send-email-andrea.gelmini@gelma.net>
Download mbox | patch
Permalink /patch/1007/
State Accepted
Delegated to: Ralf Baechle
Headers show

Comments

Andrea Gelmini - 2010-02-27 04:02:23
arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
---
 arch/mips/lib/libgcc.h |    3 +--
 arch/sh/lib/libgcc.h   |    3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)
Paul Mundt - 2010-03-01 02:03:16
On Sat, Feb 27, 2010 at 05:51:23PM +0100, Andrea Gelmini wrote:
> arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  arch/mips/lib/libgcc.h |    3 +--
>  arch/sh/lib/libgcc.h   |    3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
I'll apply the sh part by itself, and I suppose Ralf will do the same for
MIPS. I'm a bit confused as to why these were lumped together when 65 out
of 66 oneliner patches made no use of ad-hoc grouping.
Andrea Gelmini - 2010-03-02 03:03:11
2010/3/1 Paul Mundt <lethal@linux-sh.org>:
Hi Paul,
   thanks for your reply.

> I'll apply the sh part by itself, and I suppose Ralf will do the same for
> MIPS. I'm a bit confused as to why these were lumped together when 65 out
> of 66 oneliner patches made no use of ad-hoc grouping.

After the experience with GregKH, I was looking for others maintainer
interested in code cleanup. So I sent some patches over random files.
If you care, I can checkpatch.pl all mips subtree and send you patches (if any).

Thanks a lot for your work,
Andrea
Ralf Baechle - 2010-03-17 03:03:18
On Sat, Feb 27, 2010 at 05:51:23PM +0100, Andrea Gelmini wrote:
> From: Andrea Gelmini <andrea.gelmini@gelma.net>
> Date:   Sat, 27 Feb 2010 17:51:23 +0100
> To: linux-kernel@vger.kernel.org
> Cc: Andrea Gelmini <andrea.gelmini@gelma.net>,
> 	Ralf Baechle <ralf@linux-mips.org>,
> 	Paul Mundt <lethal@linux-sh.org>, linux-mips@linux-mips.org,
> 	linux-sh@vger.kernel.org
> Subject: [PATCH 42/66] arch/mips/lib/libgcc.h: Checkpatch cleanup
> 
> arch/mips/lib/libgcc.h:21: ERROR: open brace '{' following union go on the same line
> 
> Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
> ---
>  arch/mips/lib/libgcc.h |    3 +--
>  arch/sh/lib/libgcc.h   |    3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)

I've applied the MIPS portion of the patch, thanks.

  Ralf
Ralf Baechle - 2010-03-17 03:03:28
On Tue, Mar 02, 2010 at 04:13:11PM +0100, Andrea Gelmini wrote:

> 2010/3/1 Paul Mundt <lethal@linux-sh.org>:
> Hi Paul,
>    thanks for your reply.
> 
> > I'll apply the sh part by itself, and I suppose Ralf will do the same for
> > MIPS. I'm a bit confused as to why these were lumped together when 65 out
> > of 66 oneliner patches made no use of ad-hoc grouping.
> 
> After the experience with GregKH, I was looking for others maintainer
> interested in code cleanup. So I sent some patches over random files.
> If you care, I can checkpatch.pl all mips subtree and send you patches (if any).

Feel free to - but remember that the coding style document is a guideline
not something to be followed unconditionally.

  Ralf

Patch

diff --git a/arch/mips/lib/libgcc.h b/arch/mips/lib/libgcc.h
index 3f19d1c..05909d5 100644
--- a/arch/mips/lib/libgcc.h
+++ b/arch/mips/lib/libgcc.h
@@ -17,8 +17,7 @@  struct DWstruct {
 #error I feel sick.
 #endif
 
-typedef union
-{
+typedef union {
 	struct DWstruct s;
 	long long ll;
 } DWunion;
diff --git a/arch/sh/lib/libgcc.h b/arch/sh/lib/libgcc.h
index 3f19d1c..05909d5 100644
--- a/arch/sh/lib/libgcc.h
+++ b/arch/sh/lib/libgcc.h
@@ -17,8 +17,7 @@  struct DWstruct {
 #error I feel sick.
 #endif
 
-typedef union
-{
+typedef union {
 	struct DWstruct s;
 	long long ll;
 } DWunion;